CodingTests
/
mars-rover-kata
1
0
Fork 0
Code

loop the world longitudinally succesful

This commit is contained in:
Xavier Fontanet 2024-06-20 23:04:03 +02:00
parent be56b4478a
commit 20b785ef29
3 changed files with 47 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/cat/hack3/codingtests/marsrover/Coordinates.java
View File

@ -12,6 +12,10 @@ public class Coordinates {
return new Coordinates(newLatitude, longitude);
}
public Coordinates ofUpdatedLongitude(int newLongitude) {
return new Coordinates(latitude, newLongitude);
}
private Coordinates(int latitude, int longitude) {
this.latitude = latitude;
this.longitude = longitude;

12
src/main/java/cat/hack3/codingtests/marsrover/MarsMap.java
View File

@ -28,8 +28,8 @@ public class MarsMap {
switch (direction) {
case NORTH -> decrementLatitude();
case SOUTH -> incrementLatitude();
case WEST -> incrementLongitude();
case EAST -> decrementLongitude();
case WEST -> decrementLongitude();
case EAST -> incrementLongitude();
}
logger.info(String.format("Updated coordinates towards %s, now is %d-%d",
direction, currentPosition.getLatitude(), currentPosition.getLongitude()));
@ -58,7 +58,15 @@ public class MarsMap {
}
private void incrementLongitude() {
int longitude = currentPosition.getLongitude();
int newLongitude = longitude + 1 > width
? 1
: ++longitude;
setNewLongitude(newLongitude);
}
private void setNewLongitude(int newLongitude) {
currentPosition = currentPosition.ofUpdatedLongitude(newLongitude);
}
private void decrementLongitude() {

55
src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java
View File

@ -34,17 +34,6 @@ public class MarsRoverTest {
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void loopTheWorldInLatitudeMovingForward() {
Coordinates originalCoordinates = rover.getCurrentCoordinates();
Direction originalDirection = rover.getCurrentDirection();
repeatAction(10, i -> rover.moveForward());
assertEquals(rover.getCurrentCoordinates(), originalCoordinates);
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void stepBackwards() {
Direction originalDirection = rover.getCurrentDirection();
@ -55,17 +44,6 @@ public class MarsRoverTest {
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void loopTheWorldInLatitudeMovingBackwards() {
Coordinates originalCoordinates = rover.getCurrentCoordinates();
Direction originalDirection = rover.getCurrentDirection();
repeatAction(10, i -> rover.moveBackwards());
assertEquals(rover.getCurrentCoordinates(), originalCoordinates);
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void turnLef() {
assertEquals(rover.turnLeft(), EAST);
@ -84,6 +62,39 @@ public class MarsRoverTest {
assertEquals(rover.turnRight(), WEST);
}
@Test
public void loopTheWorldInLatitudeMovingForward() {
Coordinates originalCoordinates = rover.getCurrentCoordinates();
Direction originalDirection = rover.getCurrentDirection();
repeatAction(10, i -> rover.moveForward());
assertEquals(rover.getCurrentCoordinates(), originalCoordinates);
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void loopTheWorldInLatitudeMovingBackwards() {
Coordinates originalCoordinates = rover.getCurrentCoordinates();
Direction originalDirection = rover.getCurrentDirection();
repeatAction(10, i -> rover.moveBackwards());
assertEquals(rover.getCurrentCoordinates(), originalCoordinates);
assertEquals(rover.getCurrentDirection(), originalDirection);
}
@Test
public void loopTheWorldInLongitudeMovingForward() {
Coordinates originalCoordinates = rover.getCurrentCoordinates();
rover.turnLeft();
repeatAction(10, i -> rover.moveForward());
assertEquals(rover.getCurrentCoordinates(), originalCoordinates);
assertEquals(rover.getCurrentDirection(), EAST);
}
private void repeatAction(int times, IntConsumer actionToRepeat) {
IntStream.rangeClosed(1, times)
.forEach(actionToRepeat);