From cbbc40c50a594c13457d408e6cc262c194fb3a87 Mon Sep 17 00:00:00 2001 From: Xavier Fontanet Date: Sat, 22 Jun 2024 19:21:31 +0200 Subject: [PATCH] better naming description --- .../hack3/codingtests/marsrover/RotableRiderRover.java | 2 +- .../{MarsRoverCommand.java => RoverCommand.java} | 2 +- .../hack3/codingtests/marsrover/MoveBackwardsCommand.java | 2 +- .../hack3/codingtests/marsrover/MoveForwardCommand.java | 2 +- .../cat/hack3/codingtests/marsrover/TurnLeftCommand.java | 2 +- .../cat/hack3/codingtests/marsrover/TurnRightCommand.java | 2 +- .../cat/hack3/codingtests/marsrover/MarsRoverTest.java | 8 ++++---- .../marsrover/ui/console/RoverCommandsPerformer.java | 8 ++++---- 8 files changed, 14 insertions(+), 14 deletions(-) rename mars-station/src/main/java/cat/hack3/codingtests/marsrover/{MarsRoverCommand.java => RoverCommand.java} (64%) diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RotableRiderRover.java b/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RotableRiderRover.java index edff504..c4a899a 100644 --- a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RotableRiderRover.java +++ b/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RotableRiderRover.java @@ -8,7 +8,7 @@ public interface RotableRiderRover { void moveTowards(Direction direction); - void rotateTowards(MarsRover.Rotation rotation); + void rotateTowards(Rotation rotation); Coordinates getCurrentCoordinates(); diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/MarsRoverCommand.java b/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RoverCommand.java similarity index 64% rename from mars-station/src/main/java/cat/hack3/codingtests/marsrover/MarsRoverCommand.java rename to mars-station/src/main/java/cat/hack3/codingtests/marsrover/RoverCommand.java index 11ff0bf..54c139c 100644 --- a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/MarsRoverCommand.java +++ b/mars-station/src/main/java/cat/hack3/codingtests/marsrover/RoverCommand.java @@ -1,5 +1,5 @@ package cat.hack3.codingtests.marsrover; -public interface MarsRoverCommand { +public interface RoverCommand { void execute(); } diff --git a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java index 2ce694c..c6a6602 100644 --- a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java +++ b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java @@ -1,6 +1,6 @@ package cat.hack3.codingtests.marsrover; -public class MoveBackwardsCommand implements MarsRoverCommand { +public class MoveBackwardsCommand implements RoverCommand { private final RotableRiderRover rover; public MoveBackwardsCommand(RotableRiderRover rover) { diff --git a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java index d836437..3374e2c 100644 --- a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java +++ b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java @@ -1,6 +1,6 @@ package cat.hack3.codingtests.marsrover; -public class MoveForwardCommand implements MarsRoverCommand{ +public class MoveForwardCommand implements RoverCommand { private final RotableRiderRover rover; public MoveForwardCommand(RotableRiderRover rover) { diff --git a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java index 10ad037..fd2b892 100644 --- a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java +++ b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java @@ -2,7 +2,7 @@ package cat.hack3.codingtests.marsrover; import static cat.hack3.codingtests.marsrover.RotableRiderRover.Rotation.LEFT; -public class TurnLeftCommand implements MarsRoverCommand{ +public class TurnLeftCommand implements RoverCommand { private final RotableRiderRover rover; public TurnLeftCommand(RotableRiderRover rover) { diff --git a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java index f485475..8d7c12c 100644 --- a/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java +++ b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java @@ -2,7 +2,7 @@ package cat.hack3.codingtests.marsrover; import static cat.hack3.codingtests.marsrover.RotableRiderRover.Rotation.RIGHT; -public class TurnRightCommand implements MarsRoverCommand{ +public class TurnRightCommand implements RoverCommand { private final RotableRiderRover rover; public TurnRightCommand(RotableRiderRover rover) { diff --git a/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java b/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java index 5bffb3b..50fb1ee 100644 --- a/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java +++ b/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java @@ -14,10 +14,10 @@ import static org.testng.Assert.assertEquals; public class MarsRoverTest { private MarsRover rover; - private MarsRoverCommand moveForwardCommand; - private MarsRoverCommand moveBackwardsCommand; - private MarsRoverCommand turnLeftCommand; - private MarsRoverCommand turnRightCommand; + private RoverCommand moveForwardCommand; + private RoverCommand moveBackwardsCommand; + private RoverCommand turnLeftCommand; + private RoverCommand turnRightCommand; @BeforeMethod public void setUp() { diff --git a/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java b/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java index 6e9b7ff..5af1abf 100644 --- a/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java +++ b/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java @@ -9,10 +9,10 @@ import static cat.hack3.codingtests.marsrover.ui.console.UICommons.output; public class RoverCommandsPerformer { private final Scanner reader; - private final MarsRoverCommand moveForwardCommand; - private final MarsRoverCommand moveBackwardsCommand; - private final MarsRoverCommand turnLeftCommand; - private final MarsRoverCommand turnRightCommand; + private final RoverCommand moveForwardCommand; + private final RoverCommand moveBackwardsCommand; + private final RoverCommand turnLeftCommand; + private final RoverCommand turnRightCommand; public RoverCommandsPerformer(Scanner reader, RotableRiderRover rover) { this.reader = reader;