From f4fef1e9eb1ea1adca29ba0746aa31fab5910292 Mon Sep 17 00:00:00 2001
From: Xavier Fontanet <xavier.fontanet@edreamsodigeo.com>
Date: Sat, 22 Jun 2024 19:13:40 +0200
Subject: [PATCH] Achieved the Open-Closed principle for commands, and
 independently deployability!!!

---
 rover-commands/pom.xml                                       | 1 +
 .../hack3/codingtests/marsrover/MoveBackwardsCommand.java    | 0
 .../cat/hack3/codingtests/marsrover/MoveForwardCommand.java  | 0
 .../cat/hack3/codingtests/marsrover/TurnLeftCommand.java     | 0
 .../cat/hack3/codingtests/marsrover/TurnRightCommand.java    | 0
 .../java/cat/hack3/codingtests/marsrover/MarsRoverTest.java  | 0
 .../codingtests/marsrover/MarsRoverWithObstaclesTest.java    | 0
 user-interface-console/pom.xml                               | 5 +++++
 .../marsrover/ui/console/RoverCommandsPerformer.java         | 2 --
 9 files changed, 6 insertions(+), 2 deletions(-)
 rename {mars-station => rover-commands}/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java (100%)
 rename {mars-station => rover-commands}/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java (100%)
 rename {mars-station => rover-commands}/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java (100%)
 rename {mars-station => rover-commands}/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java (100%)
 rename {mars-station => rover-commands}/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java (100%)
 rename {mars-station => rover-commands}/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java (100%)

diff --git a/rover-commands/pom.xml b/rover-commands/pom.xml
index b231e35..9b219eb 100644
--- a/rover-commands/pom.xml
+++ b/rover-commands/pom.xml
@@ -10,6 +10,7 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>rover-commands</artifactId>
+    <version>1.0</version>
 
     <properties>
         <maven.compiler.source>17</maven.compiler.source>
diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java
similarity index 100%
rename from mars-station/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java
rename to rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveBackwardsCommand.java
diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java
similarity index 100%
rename from mars-station/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java
rename to rover-commands/src/main/java/cat/hack3/codingtests/marsrover/MoveForwardCommand.java
diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java
similarity index 100%
rename from mars-station/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java
rename to rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnLeftCommand.java
diff --git a/mars-station/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java b/rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java
similarity index 100%
rename from mars-station/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java
rename to rover-commands/src/main/java/cat/hack3/codingtests/marsrover/TurnRightCommand.java
diff --git a/mars-station/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java b/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java
similarity index 100%
rename from mars-station/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java
rename to rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverTest.java
diff --git a/mars-station/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java b/rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java
similarity index 100%
rename from mars-station/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java
rename to rover-commands/src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java
diff --git a/user-interface-console/pom.xml b/user-interface-console/pom.xml
index 7d67149..3b0eba7 100644
--- a/user-interface-console/pom.xml
+++ b/user-interface-console/pom.xml
@@ -22,6 +22,11 @@
             <artifactId>mars-station</artifactId>
             <version>2.0</version>
         </dependency>
+        <dependency>
+            <groupId>cat.hack3.codingtests</groupId>
+            <artifactId>rover-commands</artifactId>
+            <version>1.0</version>
+        </dependency>
     </dependencies>
 
 </project>
\ No newline at end of file
diff --git a/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java b/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java
index 3e44db9..6e9b7ff 100644
--- a/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java
+++ b/user-interface-console/src/main/java/cat/hack3/codingtests/marsrover/ui/console/RoverCommandsPerformer.java
@@ -9,7 +9,6 @@ import static cat.hack3.codingtests.marsrover.ui.console.UICommons.output;
 
 public class RoverCommandsPerformer {
     private final Scanner reader;
-    private final RotableRiderRover rover;
     private final MarsRoverCommand moveForwardCommand;
     private final MarsRoverCommand moveBackwardsCommand;
     private final MarsRoverCommand turnLeftCommand;
@@ -17,7 +16,6 @@ public class RoverCommandsPerformer {
 
     public RoverCommandsPerformer(Scanner reader, RotableRiderRover rover) {
         this.reader = reader;
-        this.rover = rover;
         moveForwardCommand = new MoveForwardCommand(rover);
         moveBackwardsCommand = new MoveBackwardsCommand(rover);
         turnLeftCommand = new TurnLeftCommand(rover);