1
0
Fork 0
Commit Graph

79 Commits

Author SHA1 Message Date
Xavier Fontanet d0f420e9c0 test invalid command case, and btw, nice to see
"InvalidCommandNameProvided: The available commands are [MOVE_FORWARD, MOVE_BACKWARDS, TURN_LEFT, TURN_RIGHT]" in response
2024-07-05 18:02:27 +02:00
Xavier Fontanet b50022b5b2 adapt user interface to new report deliver method 2024-07-05 17:51:49 +02:00
Xavier Fontanet ca9f150c23 return the ActionReport in every executed command 2024-07-05 17:47:16 +02:00
Xavier Fontanet 33cc0744a8 updated command user interface with new command factory contract 2024-07-05 17:24:17 +02:00
Xavier Fontanet 8860bfcbc0 sacrify type safety to obtain independent deployability when a command is added (now the api module doesn't need to be recompiled+redeployed) 2024-07-05 17:24:17 +02:00
Xavier Fontanet 42f1f19926 Merge remote-tracking branch 'origin/master' 2024-06-29 21:38:39 +02:00
Xavier Fontanet 042aec2621 hierarchical tests 2024-06-29 21:38:30 +02:00
xavier d043e84857 kata description 2024-06-26 14:38:17 +02:00
Xavier Fontanet 35d570241a a bit of Interface Segregation Principle
a bit of Interface Segregation Principle
2024-06-26 00:54:16 +02:00
Xavier Fontanet ed847ee613 slight clean code 2024-06-24 18:01:09 +02:00
Xavier Fontanet 8595c1c83d Merge branch 'JPMS-experimentation'
# Conflicts:
#	SOLUTION.md
#	misc/images/mars-rover_design.png
2024-06-24 17:28:23 +02:00
Xavier Fontanet 9a852b06d3 images fix 2024-06-24 17:23:01 +02:00
Xavier Fontanet d2aa5cd22f images fix 2024-06-24 17:21:37 +02:00
Xavier Fontanet 07c95b0740 design representation 2024-06-24 17:18:21 +02:00
Xavier Fontanet 02d849f696 apply JPMS to user interface module and improve some namings 2024-06-24 16:28:54 +02:00
Xavier Fontanet 0455523ed9 try to reduce boilerplate files and code, also encapsulating even more the constructors 2024-06-24 04:25:59 +02:00
Xavier Fontanet fd7306f1a1 another interface that goes to api module (command factory) 2024-06-24 01:44:14 +02:00
Xavier Fontanet d40ff90c6e slight improve on test suit 2024-06-24 01:06:30 +02:00
Xavier Fontanet 877d534716 applied JPMS. UTs working (in a self module). Big Refactor needed... (sorry for that big commit) 2024-06-24 00:45:57 +02:00
Xavier Fontanet 57bf2d3999 encapsulate all command classes from outside the module, through a Factory facade 2024-06-23 22:29:14 +02:00
Xavier Fontanet 75956705ad move the command interface to command module 2024-06-23 21:55:21 +02:00
Xavier Fontanet e02bcbc163 publish design snapshot 2024-06-23 21:34:55 +02:00
xavier 8185192fdb remove Wallapop references in readme 2024-06-23 13:04:49 +02:00
Xavier Fontanet 75cfcb1184 forgotten design improve from Latitude/Longitude Objects introduction 2024-06-22 19:47:05 +02:00
Xavier Fontanet cbbc40c50a better naming description 2024-06-22 19:21:31 +02:00
Xavier Fontanet f4fef1e9eb Achieved the Open-Closed principle for commands, and independently deployability!!! 2024-06-22 19:13:40 +02:00
Xavier Fontanet 2be1478744 some cleaning 2024-06-22 19:08:38 +02:00
Xavier Fontanet 6e966919d3 introduce rover-commands module and update versions 2024-06-22 19:03:12 +02:00
Xavier Fontanet cae3fa399e move to PositionResolver the concern of the appropiated threshold for each case 2024-06-22 18:55:33 +02:00
Xavier Fontanet 3b8595c630 better design and SRP 2024-06-22 17:51:01 +02:00
Xavier Fontanet f0f3bf31fc adapt UI to new commands design 2024-06-22 16:57:27 +02:00
Xavier Fontanet 535ae91e6c make Rover abstract to commands 2024-06-22 15:47:14 +02:00
Xavier Fontanet e247e53c64 location mistake 2024-06-22 15:30:35 +02:00
Xavier Fontanet 026195c849 simplify internal contracts of Map 2024-06-22 15:27:06 +02:00
Xavier Fontanet ff548d0338 Command pattern implemented for all current features 2024-06-22 15:11:28 +02:00
Xavier Fontanet f80460054d introduced command pattern to ease open-close principle apply 2024-06-22 14:31:42 +02:00
Xavier Fontanet d5b6775578 separate cartography related to a different package 2024-06-22 13:05:49 +02:00
Xavier Fontanet 792caa39a4 separate into different modules 2024-06-22 12:57:37 +02:00
Xavier Fontanet ca8d059292 remove some warnings 2024-06-21 19:38:13 +02:00
Xavier Fontanet ca409a9eee obstacles feature works fine 2024-06-21 19:36:57 +02:00
Xavier Fontanet afe21ad223 first obstacle feature test OK 2024-06-21 19:17:39 +02:00
Xavier Fontanet 88e6db14c0 Merge remote-tracking branch 'origin/master'
# Conflicts:
#	src/test/java/cat/hack3/codingtests/marsrover/MarsRoverWithObstaclesTest.java
2024-06-21 18:48:36 +02:00
Xavier Fontanet 04d2448863 introduce obstacles term 2024-06-21 18:46:38 +02:00
Xavier Fontanet 2c75e7d807 Revert "separate UI from business core"
This reverts commit a8e2d506fa.
2024-06-21 18:16:43 +02:00
Xavier Fontanet a8e2d506fa separate UI from business core 2024-06-21 18:13:52 +02:00
Xavier Fontanet 303d839249 split more and leave procedural programming to return to OOP 2024-06-21 18:11:08 +02:00
Xavier Fontanet 44cfcaf3ca split a bit the main class 2024-06-21 17:41:09 +02:00
Xavier Fontanet 43bd81c8e3 draft of a full command interface implementation 2024-06-21 14:40:29 +02:00
Xavier Fontanet 530cf22983 log also the rotation 2024-06-21 13:37:33 +02:00
Xavier Fontanet adbca95241 some refinements and cleaning code 2024-06-21 11:56:48 +02:00